search

ChrisWren / grunt-nodemon

Grunt task to run nodemon
MIT License
345 stars 37 forks source link

show error message correctly #1

Closed kcliu closed 11 years ago

kcliu commented 11 years ago

I just found that if i didn't install nodemon, there is no any error message.

ChrisWren commented 11 years ago

Thank you for contributing! Do you think we should have a more descriptive error which tells them how to install nodemon globally? If they just see nodemon not found it might not be clear how to resolve the issue.

How about adding this below the error log:

grunt.log.error('Make sure you have nodemon installed globally. You can install it by entering the following into your terminal:');
grunt.log.ok('npm install nodemon -g');
kcliu commented 11 years ago

I have tried this firstly, though I figure out that the error might not only be "nodemon not fund".

ChrisWren commented 11 years ago

I thought about that too. However, since this task simply launches nodemon, the errors will be outputted via nodemon and not grunt. I haven't been able to product an error in grunt, even if I do improper configuration.

If there is eventually an issue in grunt, the above warning is covering the most common case which is someone not having nodemon installed. I would rather have this meaningful warning for the common use case and if someone has some other error, they should file it as an issue.

If you know about any other errors, let me know in this thread. Otherwise, I will pull down your changes and add the extra warning. Thanks again for your contribution!

kcliu commented 11 years ago

Agree, then adding the extra meaningful warning would be fine. :)