ChrisWren / grunt-nodemon

Grunt task to run nodemon
MIT License
345 stars 37 forks source link

Updated to nodemon ~1.3.0 #52

Closed arty-name closed 9 years ago

arty-name commented 9 years ago

Fixes #46

arty-name commented 9 years ago

Looks like something is wrong with the testing environment itself, even npm install has failed there

abiyasa commented 9 years ago

I did npm info nodemon, unfortunately they only have 1.2.1 as the latest, not yet 1.3.0. The 1.3.0-x is only available for debug or dev version, which you can install by using nodemon@dev or nodemon@debug

arty-name commented 9 years ago

that's weird: exactly same version bump on my local computer didn't cause any errors, and I don't use dev or debug

abiyasa commented 9 years ago

I did npm install using package.json defined on your fix but I always got nodemon@1.2.1 installed. I tried to npm cache clean and npm install but still got v1.2.1 instead of 1.3.0.

arty-name commented 9 years ago

I see, maybe I didn't pay enough attention. Well, this upgrade will happen anyway, when non-dev version of nodemon is released, so I'll just keep this PR around :)

abiyasa commented 9 years ago

Yup, we just have to wait until nodemon release their v1.3.0 to npm registry :-)

jdoose commented 9 years ago

I am new to this, but on the nodemon github site it states that 1.3.0-1 was released (https://github.com/remy/nodemon/releases). Maybe it is just the format in the package.json in grunt-nodemon that is wrong? it works if I change it to "nodemon": "~1.3.0-0"

Or is it a convention that 1.3.0-x releases are not stable/official ones?

abiyasa commented 9 years ago

@jdoose According to semver (http://semver.org), the dash means pre-releases. This means 1.3.0-1 < 1.3.0

jdoose commented 9 years ago

@abiyasa ok, thanks for clarification! Too bad. :/

abiyasa commented 9 years ago

nodemon v1.3.0 has been released 2 days ago. The latest release version is v1.3.2. I guess it's time to merge this?

khaled-su commented 9 years ago

pls merge..

ChrisWren commented 9 years ago

Sorry for the delay.

abiyasa commented 9 years ago

Thanks for the update :thumbsup:

jdoose commented 9 years ago

Thanks for the update!