Nodemon dependency out of date

ChrisWren / grunt-nodemon

Grunt task to run nodemon

MIT License

345 stars 37 forks source link

Nodemon dependency out of date #64

Closed NullDivision closed 8 years ago

NullDivision commented 9 years ago

The nodemon package is out of date as a dependency. Current working version is v1.7.1 which has some dependencies that cause breakage in some scenarios.

For example:

In the event that the user tries to install grunt-nodemon as a dependency alongside mongoose, grunt-nodemon will require nodemon who requires touch. The version in the current dependency stack is v1.3.8 which brings touch 0.0.4. The current dependency is touch 1.0.0.

mgoldsborough commented 9 years ago

@NullDivision, I had the same problem. I just forked, updated and published v0.5.0 here:

https://www.npmjs.com/package/grunt-contrib-nodemon

NullDivision commented 9 years ago

If you fork you should probably make an even effort dude. Check pull request #65 for a proper fix.

mgoldsborough commented 9 years ago

The problem is that https://github.com/remy/nodemon doesn't specific a version in their package.json so tools like outdated don't pick it up. I just bumped nodemon to v1.7.1.

Either way, use it or don't but no need to be so abrasive.

NullDivision commented 9 years ago

NPM-s versioning behavior relies on git tags if present so explicit version declarations (while useful) aren't mandatory.

I'm abrasive because:

you basically sed replaced all mentions of the original author name/repo with your own own
you hotfixed touch but left all other dependencies untouched
you removed the mdlint requirement (not a bad point but it's there)
bumped a minor version for something that's basically a patch
didn't even bother to do a pull request for the original author

I already did this a week ago for my own project. If your intention was to do take over the project, at least make an effort is what I'm saying.

mlarcher commented 8 years ago

@ChrisWren Could you pleas update the nodemon version pulled by grunt-nodemon ? Amon other problems, the currently imported version has big performance issues when running in git-bash (cf https://github.com/remy/nodemon/issues/624 ) I see a PR is already ready, so why not merge it ?

ChrisWren commented 8 years ago

Sorry, just merged