Chrismettal / FreeCAD-Behave-dark

Behave dark theme for FreeCAD
15 stars 1 forks source link

dark blue font on dark background is hard to read #3

Closed luzpaz closed 1 year ago

luzpaz commented 4 years ago

image

Chrismettal commented 4 years ago

Yes, you are right. I would like to add font styling for the console to stylesheets but these colors can't be handled by QT and are instead done in FreeCAD display settings. The same thing applies to stuff like sketcher colors. In the future i would like to extend stylesheets to a whole theme file including a stylesheet and a config import, overwriting console colors, sketcher colors etc.

For now, i will have to choose a lighter background for the console. Will do with the tiled mode dragging fix rollout.

luzpaz commented 4 years ago

whole theme file
Great idea. How do you propose we go about this?

Chrismettal commented 4 years ago

I would like to see a single file that starts with a qss stylesheet and ends with a partial configuration file containing all the color settings that you would find in the preferences tab. Both wrapped up in an xml or whatever will be easiest to split during init or saving in the preferences dialog.

Only after splitting we would apply the stylesheet portion and overwrite all the color preference settings.

Now that i think about it FreeCAD does not yet have configuration export/import, does it? I would have liked to reuse part of that, but if it doesn't exist i see another construction site coming.

Chrismettal commented 4 years ago

Screenshot_20201018_115636 It's pretty difficult finding a compromise for the standard console colors. Anything but a pure white will make some colors hard to read, and even then green is very retina burning. Making it a bit darker makes blue vanish, a bit lighter and green turns to mud.

The original intend would be restored by setting all the syntax colors in the general settings to the ones defined in the approved colors of Behave. Until that is possible i could push this compromise color if you think that looks better? Not too sure myself.

luzpaz commented 4 years ago

hmm..not sure you should compromise. Better to have the user change them until a better solution is presented by someone.

Chrismettal commented 4 years ago

You might be right. I will probably make a list of recommended color settings for all the colors that can't be controlled by stylesheets yet.

For now i have made a commit with the compromise background which probably will be reverted then.

luzpaz commented 4 years ago

Checkout https://github.com/dulouie/FreeCAD-modern-config
Perhaps a way to force change aspects of the UI that the stylesheet can't touch

Chrismettal commented 4 years ago

Thank you. Didn't know macros have access to user parameters like all the colors. Having one such macro for every stylesheet and calling it on stylesheet change would be one possibility to achieve full theming.

On the other hand, this could be expanded to export/import user configurations completely.

Chrismettal commented 1 year ago

Handled via PreferencePacks now