search

ChristianChiarulli / nvcode-color-schemes.vim

A bunch of generated colorschemes (treesitter supported)
MIT License
300 stars 67 forks source link

Namespace color in metanoia colorscheme #53

Closed nkoturovic closed 3 years ago

nkoturovic commented 3 years ago

Namespace (Magenta) color looks odd in metanoia colorscheme

https://i.postimg.cc/gjKYNckk/meta-fix.png

@sinuheshinbr I think this vibrant magenta color is probably not intended to be like this??

sinuheshinbr commented 3 years ago

Yeah, not really. Not sure what happened there, I tried to reproduce here but std is showing as TSNamespace. You got treesitter configured with cpp lang server?

nkoturovic commented 3 years ago

@sinuheshinbr Yeah, it seems that it is actually showing TSNamespace color.

https://i.ibb.co/Lz6jcgM/metanoia-ns-color.png

Note: There are some other fields in metanoia.yml that use HEX codes directly (also very vibrant colors), maybe you've missed those?

btw, I like this colorscheme it looks very nice

sinuheshinbr commented 3 years ago

Hey, my bad, TSNamespace was blue here, I probably changed it after the PR. The vibrant colors were groups that I did not encounter so they were left behind. I chose some random colors for them, but if you are using one of those HL groups and want to suggest any color that makes more sense just let me know! Already submitted a new PR with the updates.

nkoturovic commented 3 years ago

Nice, everything else looks great. I will use this updated version some time and if I encounter some inconsistency or get some improvement idea i will bring it up.

Closed: 4c7b42fadb