search

ChristianKienle / Core-Data-Editor

Core Data Editor lets you easily view, edit and analyze applications‘ data. Core Data Editor is compatible with Mac and iOS applications and supports XML, SQLite and binary stores, visualizes all relationships and is able to edit the data and generate Objective-C code for the data model.
BSD 3-Clause "New" or "Revised" License
2.13k stars 182 forks source link

Changed init methods. #22

Closed talzag closed 10 years ago

talzag commented 10 years ago

I changed the init methods in the view controllers for the Mac project. I was getting compiler warnings when I build the project, so I changed the initWithNibName:bundle: methods to call super, and the init method now calls [self initWithNibName:bundle:]. This fixes the compiler warnings, and the app compiles and runs without any warnings or errors.

ChristianKienle commented 10 years ago

Thanks! I will add you to the list of contributors if you don't mind.

yas375 commented 10 years ago

@ChristianKienle the project doesn't compile anymore. See https://travis-ci.org/ChristianKienle/Core-Data-Editor/builds/34102862

talzag commented 10 years ago

Wow, so sorry guys. I thought I fixed the merge issues before I merged with my master branch. I apologize, I'm just starting to get involved in contributing to open source projects. I'm not sure how I messed up my code, sorry I committed junk.

talzag commented 10 years ago

There's junk in the .pbxproj files. I'll fix those ASAP.

talzag commented 10 years ago

All of the targets are building for me now. I'll commit them & issue a pull request ASAP. Again, sorry for dicking the code up so badly :/

yas375 commented 10 years ago

@talzag no worries! Keep contributing to OSS! Just be careful and always double-check what you are going to commit (git diff --cached). Also git show can be useful to double-check what you have commited in the last commit. And git show {COMMIT_SHA} will show a particular commit.

Have a good day!