Fix Unit Tests - Githubissues

ChristianKuri / laravel-favorite

Allows Laravel Eloquent models to implement a 'favorite', 'like', 'remember' and 'follow' features.

MIT License

226 stars 48 forks source link

Fix Unit Tests #10

Closed king724 closed 5 years ago

king724 commented 5 years ago

Description

Fixed typos in two test function names
Updated database assertion methods for Laravel 5.4+ support.
Fixed favoritedBy() method to return all users rather than just the last (caused failing test)

Motivation and context

All tests will now pass!

How has this been tested?

I ran composer test and all 12 tests pass.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

This will break compatibility with legacy versions of Laravel. (v5.3 and older)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My pull request addresses exactly one patch/feature.
[x] I have created a branch for this patch/feature.
[x] Each individual commit in the pull request is meaningful.
[x] I have added tests to cover my changes.
[x] If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!