Feature/deleted observer - Githubissues

ChristianKuri / laravel-favorite

Allows Laravel Eloquent models to implement a 'favorite', 'like', 'remember' and 'follow' features.

MIT License

226 stars 48 forks source link

Feature/deleted observer #17

Closed jedsonmelo closed 4 years ago

jedsonmelo commented 4 years ago

Description

Add observer in favoriteable model to delete favorites when deleted.

Motivation and context

If model favoriteable is favorited by a user and it is deleted it may cause exceptions in Favoriteability's methods as a favorite(class_name)

How has this been tested?

added one article as a favorite for two users and deleted the article and see if the records have been deleted from favorites table.

Types of changes

What types of changes does your code introduce?

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read the CONTRIBUTING document.
[x] My pull request addresses exactly one patch/feature.
[x] I have created a branch for this patch/feature.
[x] Each individual commit in the pull request is meaningful.
[x] I have added tests to cover my changes.
[x] If my change requires a change to the documentation, I have updated it accordingly.