search

ChristianKuri / laravel-favorite

Allows Laravel Eloquent models to implement a 'favorite', 'like', 'remember' and 'follow' features.
MIT License
226 stars 48 forks source link

Support for Laravel 8.0 #23

Closed MimisK13 closed 3 years ago

MimisK13 commented 4 years ago

Description

Add Support for Laravel 8.0

chaseconey commented 4 years ago

@ChristianKuri any chance we could get this merged?

ChristianKuri commented 3 years ago

Does anyone cant use this package unless this is merged? and what's the exact change that needs to be made?

MimisK13 commented 3 years ago

There is no need to make any changes to the code. You can ignore this PR and just add some more versions.

Something like that

        "illuminate/support": ">=5.4|^8.0",
        "illuminate/database": ">=5.4|^8.0",
        "php" : ">=5.6.4|^7.2"

Take a look at Files Change for versions.

ChristianKuri commented 3 years ago

The >=5.4 means that anything above or equal to 5.4 will work, that includes 6.0, 7.0, 8.0 and above, if I see that in the future a major version breaks the package I can simply limit that version or update my code and include that version.

Thank you for your pull request!

MimisK13 commented 3 years ago

@ChristianKuri you must update orchestra/testbench

    "require-dev": {
        "orchestra/testbench": "~3.4",          "orchestra/testbench": "~3.4|^5.0|^6.0",
    },

Currently not compatible with Laravel 8.