search

Christianhoej / FlexicuV2

0 stars 0 forks source link

Et par rettelser #155

Open nordfalk opened 5 years ago

nordfalk commented 5 years ago

1) Jeg mangler skriveadgang til jeres repo

2) I mangler nogle drawables i repoet:

Kun i aflevering/app/src/main/res/drawable: fle_logo.png
Kun i aflevering/app/src/main/res/drawable: icu_logo.png
Kun i aflevering/app/src/main/res/drawable: logo_hvid_skrift.png
Kun i aflevering/app/src/main/res/drawable: profile_icon.jpg
Kun i aflevering/app/src/main/res/drawable: qmark.png
Kun i aflevering/app/src/main/res/drawable: tjek.PNG
Kun i aflevering/app/src/main/res/drawable: x_logo.png
Kun i aflevering/app/src/main/res/layout: startskærm

Derfor får man disse fejl hvis man tjekker repo'et ud

/home/j/android/studenterprojekter/BrInt/gr27_flexicu/repo/app/src/main/res/layout/bekraeftelse_aftale_indgaaet.xml:34: error: resource drawable/tjek (aka com.example.chris.flexicuv2:drawable/tjek) not found.
/home/j/android/studenterprojekter/BrInt/gr27_flexicu/repo/app/src/main/res/layout/bekraeftelse_bud_medarbejder_fragment.xml:33: error: resource drawable/tjek (aka com.example.chris.flexicuv2:drawable/tjek) not found.
/home/j/android/studenterprojekter/BrInt/gr27_flexicu/repo/app/src/main/res/layout/bekraeftelse_medarbejder_udbud_fragment.xml:34: error: resource drawable/tjek (aka com.example.chris.flexicuv2:drawable/tjek) not found.
/home/j/android/studenterprojekter/BrInt/gr27_flexicu/repo/app/src/main/res/layout/burger_menu_top.xml:16: error: resource drawable/logo_hvid_skrift (aka com.example.chris.flexicuv2:drawable/logo_hvid_skrift) not found.
/home/j/android/studenterprojekter/BrInt/gr27_flexicu/repo/app/src/main/res/layout/loading_screen_fragment.xml:32: error: resource drawable/fle_logo (aka com.example.chris.flexicuv2:drawable/fle_logo) not found.
/home/j/android/studenterprojekter/BrInt/gr27_flexicu/repo/app/src/main/res/layout/loading_screen_fragment.xml:40: error: resource drawable/x_logo (aka com.example.chris.flexicuv2:drawable/x_logo) not found.
/home/j/android/studenterprojekter/BrInt/gr27_flexicu/repo/app/src/main/res/layout/loading_screen_fragment.xml:47: error: resource drawable/icu_logo (aka com.example.chris.flexicuv2:drawable/icu_logo) not found.
/home/j/android/studenterprojekter/BrInt/gr27_flexicu/repo/app/src/main/res/layout/login_screen_akt.xml:29: error: resource drawable/fle_logo (aka com.example.chris.flexicuv2:drawable/fle_logo) not found.
/home/j/android/studenterprojekter/BrInt/gr27_flexicu/repo/app/src/main/res/layout/login_screen_akt.xml:37: error: resource drawable/x_logo (aka com.example.chris.flexicuv2:drawable/x_logo) not found.
/home/j/android/studenterprojekter/BrInt/gr27_flexicu/repo/app/src/main/res/layout/login_screen_akt.xml:44: error: resource drawable/icu_logo (aka com.example.chris.flexicuv2:drawable/icu_logo) not found.
/home/j/android/studenterprojekter/BrInt/gr27_flexicu/repo/app/src/main/res/layout/new_user_fragment_2.xml:132: error: resource drawable/qmark (aka com.example.chris.flexicuv2:drawable/qmark) not found.
nordfalk commented 5 years ago

Fint at I tjekker for om der er netværksforbindelse. Ved skiftende netværk kan et netværkskald dog godt gå galt selvom telefonen mener at der er netværk,

Jeres CVR_Opslag giver ret mange følgefejl hvis netværkskaldet fejler og crasher app'en. I stedet skulle resten af metoden springes over og I skulle håndtere muligheden for netværksfejl i onPostExecute i stedet for bare at antage at map!=null:

        @Override
        protected void onPostExecute(Void aVoid) {
            super.onPostExecute(aVoid);
            if (map==null) return; //ØV
            System.out.println(map.get(cvr_opslag.getAdresseString()) + "Jeg kan finde den!");
            updateNewUser.updateAdresse(map.get(cvr_opslag.getAdresseString()));
            updateNewUser.updateVirksomhedsNavn(map.get(cvr_opslag.getVirksomhedsNavnString()));
            updateNewUser.updatePostNr(map.get(cvr_opslag.getPostNrString()));
            updateNewUser.updateBy(map.get(cvr_opslag.getByString()));
        }