MDA Deliverable 3 Feedback

[albina23]

Hi Christina,

Great work on your third MDA deliverable! Please see more detailed feedback below:

• Ex 1.1: Great use of forcats package to reorder your categorical variable, fantastic plot.
• Ex 1.2: Great illustration of year() function from lubridate package.
• Ex 2.1: Great use of lm() to build a simple linear regression model. However, your research question (If investigating times of falling leaves for different tree species, how will it affect each area of Vancouver with different colors of trees, amount of tree shadow, etc?) is too broad and does not connect directly to your model.
• Ex 2.2: In this exercise, you were asked to "Produce something relevant from your fitted model: either predictions on Y, or a single value like a regression coefficient or a p-value" using functions from broom package. Using print() function was not sufficient.
• Ex 3.1: Great use of write_csv() and here::here() to save the summary table as a .csv document.
• Ex 3.2: Good use of saveRDS() here::here() to save the model statistics as a .RDS document. Your code is missing .rds extension in the file name. You needed to write: saveRDS(answer2.1, here::here("output", "binary_size_age_linear_model.RDS")) and model <- readRDS(here::here("output", "binary_size_age_linear_model.RDS"))
• Tidy submission:
  • Good overview of your repo in README.md.
  • README.md should have also contained a high-level description of your project and included a list and description of all the files in your repo.
  • Mini_Data_Analysis_1_files folder should have been placed inside Milestone 1 folder, mini-project-2_files inside Milestone 2 folder, and mini-project-3_files inside Milestone 3 folder.
  • Images included in the Mini_Data_Analysis_1_files folder have also been incorrectly copied in the main repo as well as in the Milestone 1 folder.
  • Because of the incorrect folder structure, none of the graphs in the knitted .md files are rendering properly.
  • Milestone 2 and Milestone 3 folders are also missing their README.md files.
  • Finally, you are also missing a release for Milestone 3.

Please let me know if you have any questions. Grades will be posted soon on Canvas.

Best, Albina

[Christina663]

Hi Albina,

Thank you so much for your detailed feedback and I really appreciate your patience viewing my work.

It seems like I might have misled you to the wrong Github repository for my final submission. From your comments I think you were referring to my Github repository Christina_Mini_Data_Analysis https://github.com/Christina663/Christina_Mini_Data_Analysis? Whereas I actually submitted this new repository Christina_Mini_Data https://github.com/Christina663/Christina_Mini_Data on Canvas with folder structures organized out.

I believe that the errors you pointed out from the "tidy submission " part of the comments were all fixed in this new repository. Would you mind taking a look, please? I just would like to make sure that you were referring to my latest repository for grading the work. I apologize for causing confusion with two repositories with similar names.

Thank you so much, Christina Sun

On Sun, Nov 7, 2021 at 2:41 AM Albina Gibadullina @.***> wrote:

Hi Christina,

Great work on your third MDA deliverable! Please see more detailed feedback below:

• Ex 1.1: Great use of forcats package to reorder your categorical variable, fantastic plot.
• Ex 1.2: Great illustration of year() function from lubridate package.
• Ex 2.1: Great use of lm() to build a simple linear regression model. However, your research question (If investigating times of falling leaves for different tree species, how will it affect each area of Vancouver with different colors of trees, amount of tree shadow, etc?) is too broad and does not connect directly to your model.
• Ex 2.2: In this exercise, you were asked to "Produce something relevant from your fitted model: either predictions on Y, or a single value like a regression coefficient or a p-value" using functions from broom package. Using print() function was not sufficient.
• Ex 3.1: Great use of write_csv() and here::here() to save the summary table as a .csv document.
• Ex 3.2: Good use of saveRDS() here::here() to save the model statistics as a .RDS document. Your code is missing .rds extension in the file name. You needed to write: saveRDS(answer2.1, here::here("output", "binary_size_age_linear_model.RDS")) and model <- readRDS(here::here("output", "binary_size_age_linear_model.RDS"))
• Tidy submission:
  • Good overview of your repo in README.md.
  • README.md should have also contained a high-level description of your project and included a list and description of all the files in your repo.
  • Mini_Data_Analysis_1_files folder should have been placed inside Milestone 1 folder, mini-project-2_files inside Milestone 2 folder, and mini-project-3_files inside Milestone 3 folder.
  • Images included in the Mini_Data_Analysis_1_files folder have also been incorrectly copied in the main repo as well as in the Milestone 1 folder.
  • Because of the incorrect folder structure, none of the graphs in the knitted .md files are rendering properly.
  • Milestone 2 and Milestone 3 folders are also missing their README.md files.
  • Finally, you are also missing a release for Milestone 3.

Please let me know if you have any questions. Grades will be posted soon on Canvas.

Best, Albina

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Christina663/Christina_Mini_Data_Analysis/issues/6, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQX4MAAEOM3B4I343DUQEZTUKZJWRANCNFSM5HQVM7ZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[albina23]

Hi Christina,

Thank you so much for the message and for letting me know that you have submitted a different version of the milestone. You are correct that I marked the wrong version - my apologies for this and thank you for pointing this out. I updated your grades on Canvas after increasing your marks for a tidy submission to 9/10. 1 point was taken off for not including a description of every file in the repository in the primary README.md file. Other than that, everything else looks great! Great job!

Thanks for noticing the error, Albina