search

ChristoWolf / vagrant-story-randomizer

A tool for randomizing a binary of the PS1 game "Vagrant Story"
GNU General Public License v3.0
4 stars 0 forks source link

chore: improved error output of `psximager.Execute` #27

Closed ChristoWolf closed 1 year ago

ChristoWolf commented 1 year ago

Resolves #26.

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.43% // Head: 82.60% // Decreases project coverage by -14.82% :warning:

Coverage data is based on head (3186246) compared to base (4b8eb8d). Patch coverage: 63.63% of modified lines in pull request are covered.

:exclamation: Current head 3186246 differs from pull request most recent head c256507. Consider uploading reports for the commit c256507 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #27 +/- ## =========================================== - Coverage 97.43% 82.60% -14.83% =========================================== Files 5 5 Lines 39 46 +7 =========================================== Hits 38 38 - Misses 1 8 +7 ``` | [Impacted Files](https://codecov.io/gh/ChristoWolf/vagrant-story-randomizer/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [internal/psximager/psxinject.go](https://codecov.io/gh/ChristoWolf/vagrant-story-randomizer/pull/27/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-aW50ZXJuYWwvcHN4aW1hZ2VyL3BzeGluamVjdC5nbw==) | `20.00% <0.00%> (-67.50%)` | :arrow_down: | | [internal/psximager/common.go](https://codecov.io/gh/ChristoWolf/vagrant-story-randomizer/pull/27/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-aW50ZXJuYWwvcHN4aW1hZ2VyL2NvbW1vbi5nbw==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ChristoWolf commented 1 year ago

Need to increase coverage. Done.

@AmenAnthem: Don't let the pipeline failure fool you, that's a codecov bug. Executing the action again might make it green.