search

ChristophHaag / SteamVR-OpenHMD

SteamVR plugin for using OpenHMD drivers in SteamVR
Boost Software License 1.0
194 stars 33 forks source link

Rift S Controllers: Thumbsticks only registered in the first quadrant #42

Closed witty91 closed 4 years ago

witty91 commented 4 years ago

Hi, when using the Rift S Controllers in SteamVR Home, I noticed that the thumbsticks only register an input, when it is within the first quadrant (so, positive x and y values). I have been looking through the code but haven't found anything. So I would like to ask two questions: 1) Does anyone else have this problem? (It does work in windows, so the hardware should be fine...) 2) Can anyone else find a bug in the code that I couldn't?

thaytan commented 4 years ago

2nd time I've seen something similar reported. I just double checked, and OpenHMD is outputting the full range of the stick, but it does it over -1.0 to 1.0... perhaps SteamVR is expecting 0.5 as the rest position, and 0..1.0 as the output range

witty91 commented 4 years ago

That might actually have been me on another thread...since I couldn't figure the issue out until now, I thought I should create a separate issue. From what I found online -1 to 1 should be the correct range. I'll try to find the link to this information again.

thaytan commented 4 years ago

Check using OpenHMD's simple example that you're getting the same range I am:

./build/openhmd_simple_example 1

and then move the left controller stick and watch the controls state line for example.

thaytan commented 4 years ago

Ah, I see the problem - all the analog controls are reported to SteamVR as VRScalarUnits_NormalizedOneSided, but that should only apply to trigger and grip controls. The joystick report is VRScalarUnits_NormalizedTwoSided

witty91 commented 4 years ago

Yes, that fixes it! For now I have just changed "VRScalarUnits_NormalizedOneSided" line 300 in driver_openhmd.cpp to "*TwoSided" and don't see any adverse effects. I reckon another if condition to catch the thumbsticks would be better, but I am not sure by what property I could get them.

Anyways, this is working really well! I finally can turn left :-D

thaytan commented 4 years ago

Thanks! I'll make a patch

thaytan commented 4 years ago

Please update and test! :)

witty91 commented 4 years ago

I just had some time to try it out, and it works perfectly fine! :) Now I only need to map the buttons correctly for Skyrim VR and one could at least play as a caster, where you don't need to wave a sword around :D

thaytan commented 4 years ago

If you know how input mappings work... feel free to email me and explain :)

witty91 commented 4 years ago

I have managed to recreate the SteamVR Home bindings from windows, so I can use the tools to draw and so on. The way I do this is: 1) Find the bindings on windows 2) In SteamVR Home open the menu and configure the buttons through their interface 3) Use an xbox360 controller if I screw up the mapping inbetween Since I'm not at my Desktop PC for the weekend, I'll try to create a mapping for SkyrimVR next week. I could create a more detailed guide of that process if that's helpful :)