ChristophHaag / SteamVR-OpenHMD

SteamVR plugin for using OpenHMD drivers in SteamVR
Boost Software License 1.0
194 stars 33 forks source link

Fixes incorrect file location in install_files_to_build.sh #47

Closed hanaral closed 3 years ago

hanaral commented 3 years ago

Originally moved driver_openhmd.so to /bin/ and renamed to linux64 instead of moving it to /bin/linux64/ should fix same problem with windows build

Doomsdayrs commented 3 years ago

Still existing, Had a fun time reading logs and figuring out I had to create directories manually

thaytan commented 3 years ago

Still existing, Had a fun time reading logs and figuring out I had to create directories manually

You should not have had to create the dirs manually. I wonder if the problem is actually about which shell is providing /bin/sh - The braces glob in mkdir -p build/bin/{win64,win32,osx64,osx32,linux64,linux32} might be a bash feature.

What does /bin/sh --version print for you?

hanaral commented 3 years ago

Pretty sure the commit fixed this on my end, please say so if you can reproduce this on standard bash.

Doomsdayrs commented 3 years ago

Still existing, Had a fun time reading logs and figuring out I had to create directories manually

You should not have had to create the dirs manually. I wonder if the problem is actually about which shell is providing /bin/sh - The braces glob in mkdir -p build/bin/{win64,win32,osx64,osx32,linux64,linux32} might be a bash feature.

What does /bin/sh --version print for you? That command doesn't work for me

mkdir -p build/bin/{win64,win32,osx64,osx32,linux64,linux32} Creates this mess (I created the linux64 server) image

thaytan commented 3 years ago

mkdir -p build/bin/{win64,win32,osx64,osx32,linux64,linux32} Creates this mess

I think we found the reason then. In that case changing the first line of the install script from #!/bin/sh to #!/bin/bash ought to fix it.

hanaral commented 3 years ago

Damn, I should look up the correct way to do bash scripts next time I 'fix' something lol

thaytan commented 3 years ago

Damn, I should look up the correct way to do bash scripts next time I 'fix' something lol

Do you feel like revising this PR, or should we close it and I'll push a fix?

hanaral commented 3 years ago

It might be simpler to do that, since its literally a change in wording

thaytan commented 3 years ago

OK, done - 76bd59acd4e1e94e082b6de2432be8a9f213099f