Closed ciriousjoker closed 11 months ago
🙏 could you please merge this @ChristopheCVB ? do you need any help ? (I'm quite new to strapi but maybe I or others could help)
Is the plugin still working with older versions of strapi with this update?
@ChristopheCVB Haven't tried it, but it probably does, unless strapi requires this exact version and ignores their own future versions that are (assuming they follow semver) backwards compatible.
Just create a new strapi project on the lowest strapi version you'd like to support and see if it installs.
Unfortunately I'm too busy for that and I don't know what versions you want to support anyway
haven't tested it for now, I guess the minium version to test this PR on is 4.11 as it is the one marked in package.json :
haven't tested it for now, I guess the minium version to test this PR on is 4.11 as it is the one marked in package.json : https://github.com/ChristopheCVB/strapi-plugin-soft-delete/blob/e504c09aeb20e39caf5ff2da65255afb3dc91c09/package.json#L41
Exaclty
hello @ChristopheCVB, did you manage to test the PR against the minimum version you want it to be compatible with ?
Nope, didn't manage to find the time to test it yet, hopefully this week
Taken care in latest release
What does it do?
Adds compatibility with Strapi 4.14.5 & 4.15.0 (those were tested).
Why is it needed?
npm install
fails otherwise, unless you use--force
or--legacy-peer-deps
, which can produce incredibly weird and hard to fix bugs.How to test it?
It will install, but it will complain at runtime about a missing
./dist
folder, but that's expected.Related issue(s)/PR(s)
n/a