ChristopheCVB / strapi-plugin-soft-delete

Powerful Strapi based Soft Delete feature, never loose content again
MIT License
15 stars 4 forks source link

Update package.json #4

Closed ciriousjoker closed 11 months ago

ciriousjoker commented 1 year ago

What does it do?

Adds compatibility with Strapi 4.14.5 & 4.15.0 (those were tested).

Why is it needed?

npm install fails otherwise, unless you use --force or --legacy-peer-deps, which can produce incredibly weird and hard to fix bugs.

How to test it?

  1. Update to Strapi 4.14.5
  2. Install the forked repository

It will install, but it will complain at runtime about a missing ./dist folder, but that's expected.

Related issue(s)/PR(s)

n/a

t-fritsch commented 12 months ago

🙏 could you please merge this @ChristopheCVB ? do you need any help ? (I'm quite new to strapi but maybe I or others could help)

ChristopheCVB commented 12 months ago

Is the plugin still working with older versions of strapi with this update?

ciriousjoker commented 12 months ago

@ChristopheCVB Haven't tried it, but it probably does, unless strapi requires this exact version and ignores their own future versions that are (assuming they follow semver) backwards compatible.

Just create a new strapi project on the lowest strapi version you'd like to support and see if it installs.

Unfortunately I'm too busy for that and I don't know what versions you want to support anyway

t-fritsch commented 12 months ago

haven't tested it for now, I guess the minium version to test this PR on is 4.11 as it is the one marked in package.json :

https://github.com/ChristopheCVB/strapi-plugin-soft-delete/blob/e504c09aeb20e39caf5ff2da65255afb3dc91c09/package.json#L41

ChristopheCVB commented 11 months ago

haven't tested it for now, I guess the minium version to test this PR on is 4.11 as it is the one marked in package.json : https://github.com/ChristopheCVB/strapi-plugin-soft-delete/blob/e504c09aeb20e39caf5ff2da65255afb3dc91c09/package.json#L41

Exaclty

t-fritsch commented 11 months ago

hello @ChristopheCVB, did you manage to test the PR against the minimum version you want it to be compatible with ?

ChristopheCVB commented 11 months ago

Nope, didn't manage to find the time to test it yet, hopefully this week

ChristopheCVB commented 11 months ago

Taken care in latest release