nus-se-bot
commented
3 years ago Team's Response
I beg to argue with your problem report. From what we perceive in reality, ISBN for books keeps changing over time. ISBNs were 10 digits in length up to the end of December 2006, but since 1 January 2007 they now always consist of 13 digits. You won't know how number of ISBN bits will increase in the future (since there will be more and more books in the world) and if we set a hard upper limit, it will cause problems for future usage since it might exceed the limit and cause error messages. To achieve a better compatibility for older and newer books, we did not set a maximum number of digits for ISBN.
Items for the Tester to Verify
:question: Issue response
Team chose [response.Rejected]
- [x] I disagree
Reason for disagreement: I strongly feel that there is a need to implement a hard limit for ISBN numbers. If the user inputs a huge number such that it causes overflow, the program should be able to handle this and reject the input. Another point to note is that the hard limit can be a value perhaps e.g 50, such that over the next century even if the ISBN number as you mentioned increases in terms of number of digits, it will not reach the limit that you set of 50. Hence, the argument of it causing problems for future usage seems weak in this case. Personally, this feels like an oversight from adapting the constraints from AB3, there should be considerations with regards to the type, length, format, etc of the input that each parameter can accept.
:question: Issue severity
Team chose [severity.Low]
Originally [severity.Medium]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
No details provided.
Long ISBN numbers that are unrealistic are accepted by the command