search

Christopher-LM / pe

0 stars 0 forks source link

Add command can take it more than 1 langauge parameter #11

Open Christopher-LM opened 4 years ago

Christopher-LM commented 4 years ago

No details provided. Screenshot 2020-11-13 at 1.05.00 PM.png Screenshot 2020-11-13 at 1.05.03 PM.png

This bug should be fixed or an error message displayed if more than one paramter is keyed in

nus-se-bot commented 3 years ago

Team's Response

Hi, thank you for your report! : ) We are glad and grateful that you have spent the effort to try out and test our products. We appreciate your effort in trying to help us further polish our product. We understand that you might have some confusions in some of our features. We would love to explain and elaborate more on this. However, after careful consideration and discussion, we decide to reject this problem.

Firstly, we decide that this shall not be considered as a severity High problem. By referring to the CS2103 website standard closely, we decide to change the severity level of this report to VeryLow. This is because this design of ours does not affect the usage of application. Most books are written in one language and thus the add command will always takes in the last language entered. As it can be shown from the above screenshot, the last language inputted, which is "mandarin", is successfully added to the new book. The language input is still valid under this situation.

Secondly, we decide to reject the problem. The reason is that this behaviour of add command inherits from AB3. In AB3 add command, if the user input duplicate same prefix such as multiple (name of contact) n/ , multiple (phone of the contact)p/, multiple (email of the contact)e/, etc, the application will always only consider the last one inputted. In AB3, though every person has only one name, one email, and one phone, but AB3 add command still can take more than one n/, p/ or e/ parameters and only considers the last one inputted.(such as add n/John Doe n/Test p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 t/friends, then the contact named "Test" would be added) This behaviour is the same. Thus we will reject the problem.

image.png

With the given the reasons, our team decided to reject the issue. Thank you again for your response, and our team hopes that you can understand our decision.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: [replace this with your reason]