search

Christopher-LM / pe

0 stars 0 forks source link

Description or PR should not accept jsut an integer #13

Open Christopher-LM opened 4 years ago

Christopher-LM commented 4 years ago

No details provided. Screenshot 2020-11-13 at 1.14.41 PM.png

Integer can be editted into the PR which deosnt make sense

nus-se-bot commented 3 years ago

Team's Response

We have decided to downgrade the severity from High to VeryLow, change the bug type from FunctionalityBug to FeatureFlaw, and reject this issue because this does not affect usage in any cases.

Firstly, I will explain why we changed the bug type. We have clearly stated in the user guide that "problem description should only contain alphanumeric characters and spaces, and it should not be blank", so accepting a single number as description is consistent with our consideration, it should certainly not be reported as a FunctionalityBug, it should at most be considered as a FeatureFlaw.

Secondly, I will explain why we downgraded the severity and rejected it. The "problem report" feature works perfectly well for any reasonable input. An reasonable problem description can have both number and alphabets (e.g. level 1 floor is dirty), that's why we allow the input to have numbers. It might be too harsh to say that our app should not have accepted a single number as input, because it is the user's business to make sure he can understand what he has entered earlier, our job is just to make sure that any reasonable input is allowed. For instance, if a user has the habit to use "s/high d/2" to represent "level 2 door is not locked", then just go for it, we should not disallow this action. On the other hand, if we should reject single number as inputs simply because they seem unreasonable to you, perhaps we should also handle the cases such as "test" "book is 1111" because they make no sense either, but it is clearly too harsh on our app.

Additionally, you need not have to edit PR so that the description can be integer, if you directly report a problem, say "report s/high d/0", our app will also happily accept it : )

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your reason]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: [replace this with your reason]