ChristopherBThai / Discord-OwO-Bot

A Discord bot that will keep track of your OwO
https://discordapp.com/oauth2/authorize?client_id=408785106942164992&permissions=1074120776&scope=bot
Other
560 stars 404 forks source link

Repeated logic leading to message quirk #292

Open ms5984 opened 1 year ago

ms5984 commented 1 year ago

owo-bot-bug-report-sane I have traced this back to crate.js#openCrate and lootbox.js#openMultiple, wherein the latter does not take the opportunity to consolidate common logic and/or simply delegate to the existing #openBox method (which is currently used only on execute of no-args!). I haven't done much js but I'd like to try either 1) writing conditional message code or 2) refactoring lootbox.js execute to more closely resemble crate.js execute and deduplicate common code in the process 🙂

Caviarbro commented 1 year ago

Just a side note if you want to censor your name don't forget to censor the weapon id as well LOL! 😆

ms5984 commented 1 year ago

Noted :P