search

ChristopherBThai / Discord-OwO-Bot

A Discord bot that will keep track of your OwO
https://discordapp.com/oauth2/authorize?client_id=408785106942164992&permissions=1074120776&scope=bot
Other
560 stars 404 forks source link

No passive fix #317

Closed Caviarbro closed 1 year ago

Caviarbro commented 1 year ago

Fixed an edge case when a weapon would generate without passive.

Changes made by: @Togira123

image

ChristopherBThai commented 1 year ago

Couple of things, if a passive fails to be added. I would just let the user keep the weapon without a passive. Better luck next time! (obviously a feature not a bug).

And I did briefly look into this and its not the query that fails... I have logs of all mysql queries and none of the passive queries have failed. Not too sure what makes the no passive issues occur... but unfortunately this PR won't fix the issue :(

Caviarbro commented 1 year ago

Couple of things, if a passive fails to be added. I would just let the user keep the weapon without a passive. Better luck next time! (obviously a feature not a bug).

And I did briefly look into this and its not the query that fails... I have logs of all mysql queries and none of the passive queries have failed. Not too sure what makes the no passive issues occur... but unfortunately this PR won't fix the issue :(

I have some news on this! I have managed to reproduce it on my self hosted bot - this happens when the weapon (uwid) exists in the user_weapon dataset but doesn't exist in user_weapon_passives dataset.