ChristopherBThai / Discord-OwO-Bot

A Discord bot that will keep track of your OwO
https://discordapp.com/oauth2/authorize?client_id=408785106942164992&permissions=1074120776&scope=bot
Other
560 stars 404 forks source link

Remove "User Left Discord" from ranking #321

Open munikatoch opened 1 year ago

munikatoch commented 1 year ago

Can we remove the users who have deleted discord account that is the users that show as "User Left Discord" in ranking? They can't play the bot anymore and I think their data should also not exist. Just recommendation. This might help new players to get better rankings and motivate them to go higher. Personally when I see that I am below someone who is no longer playing just demotivates.

Togira123 commented 1 year ago

These users just don't share a common server with the bot, they still exist on discord (I'm pretty sure at least) so they could join back a server and start playing any time which is why I don't think they should be removed from the leaderboards.

munikatoch commented 1 year ago

Okay that make sense. But I am still unclear on this as if that was the case then the bot should be able to access the server profile and not the discord profile. Also it should be storing the discord data only for use case like when a user changes their username.

nganhduy commented 1 year ago

Okay that make sense. But I am still unclear on this as if that was the case then the bot should be able to access the server profile and not the discord profile. Also it should be storing the discord data only for use case like when a user changes their username.

when user changes their username, they have to use OwO's command to trigger the bot so the bot will know when user has changed their name or OwO has to fetch server member to see if there is any user that has changed their username or "deleted user", imagine OwO keeps scanning 3mil servers, that will make the bot slow.

munikatoch commented 1 year ago

But still, it has to compare with something. Right, to know if I am a new user or if I have changed my username. But I think I am satisfied for now. Can we add the total user count at least so that we can see how many percentage people are above us or below us?