ChristopherBThai / Discord-OwO-Bot

A Discord bot that will keep track of your OwO
https://discordapp.com/oauth2/authorize?client_id=408785106942164992&permissions=1074120776&scope=bot
Other
571 stars 407 forks source link

Make Rune of Celebration unsellable #341

Closed Caviarbro closed 1 year ago

Caviarbro commented 1 year ago

I feel like there is going to be the same issue as with Rune of the Forgotten which is also limited weapon and many people have accidentally sold it, so making Rune of Celebration unsellable would prevent that.

sfk-steelsong commented 1 year ago

if it's unsellable it can't be rerolled

Caviarbro commented 1 year ago

if it's unsellable it can't be rerolled

Well, I haven't realized this. Probably the best idea would be to introduce your Favorite weapons pull request.

atifnimran commented 1 year ago

N

Caviarbro commented 1 year ago

@sfk-steelsong I added a new property called unrerollable which would determine if a weapon can be rerolled or not instead of unsellable

Togira123 commented 1 year ago

@sfk-steelsong I added a new property called unrerollable which would determine if a weapon can be rerolled or not instead of unsellable

rename it to "rerollable" instead, having booleans that have a negative meaning is confusing and bad practice

Caviarbro commented 1 year ago

@sfk-steelsong I added a new property called unrerollable which would determine if a weapon can be rerolled or not instead of unsellable

rename it to "rerollable" instead, having booleans that have a negative meaning is confusing and bad practice

Unsellable is also a thing so I made it the same but sure.

Togira123 commented 1 year ago

@sfk-steelsong I added a new property called unrerollable which would determine if a weapon can be rerolled or not instead of unsellable

rename it to "rerollable" instead, having booleans that have a negative meaning is confusing and bad practice

Unsellable is also a thing so I made it the same but sure.

Ah yes I see alright... if you do rename it make sure to add that property to every other weapon as well and set it to true ;)

ChristopherBThai commented 1 year ago

crune will stay sellable since you can obtain multiple. It will be back next year.