search

ChristopherBThai / Discord-OwO-Bot

A Discord bot that will keep track of your OwO
https://discordapp.com/oauth2/authorize?client_id=408785106942164992&permissions=1074120776&scope=bot
Other
563 stars 404 forks source link

Staff of purity + mtap not recovering wp in turn 1 #342

Closed jay-ir closed 1 year ago

jay-ir commented 1 year ago

Screenshot_2023-03-21-06-48-30-565_com android chrome Screenshot_2023-03-21-06-48-55-733_com android chrome

The effect of mtap isn't triggered at turn 1 of battle even though debuff is successful and damage has clearly been dealt to enemy. This behaviour is consistent and as such is detrimental to pstaff.

Caviarbro commented 1 year ago

This happens with every passive using the postAttack function.

I don't know exactly why and where the bug appears but it's something near this line.

https://github.com/ChristopherBThai/Discord-OwO-Bot/blob/e21e4c3bdf312d40009671f10d03f1c83a71e1ee/src/commands/commandList/battle/WeaponInterface.js#L337

Caviarbro commented 1 year ago

The effect of mtap isn't triggered at turn 1 of battle even though debuff is successful and damage has clearly been dealt to enemy. This behaviour is consistent and as such is detrimental to pstaff.

Fixed in PR: https://github.com/ChristopherBThai/Discord-OwO-Bot/pull/340/commits/d45d0ec27845a4649526da41b7edde4ae13dac8b

jay-ir commented 1 year ago

Fixed