ChristopherBThai / Discord-OwO-Bot

A Discord bot that will keep track of your OwO
https://discordapp.com/oauth2/authorize?client_id=408785106942164992&permissions=1074120776&scope=bot
Other
556 stars 407 forks source link

Bug Fix: Unused Column #349

Closed Wifus closed 11 months ago

Wifus commented 1 year ago

The rrcount column in the user_weapon table is not being used! Added a query in the fetchNewWeapon function to update this column in order to give it use. Right now all the entries in that column are 0 in the database!

Also, since I changed fetchNewWeapon to be async I also made sure to add await before each invocation of fetchNewWeapon.

This information would be nice to have when I add some weapon utils to snail!

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

atifnimran commented 1 year ago

Please me

ChristopherBThai commented 1 year ago

Question, should rrcount be:

IMO if users want to show off a "pristine" weapon the ladder would be better. Rerolling without accepting the changes shouldn't put dirt on the weapon. Thoughts?

Wifus commented 1 year ago

From what I've seen and what weapon utility bots offer, players like to know "how much effort" was put into rerolling a weapon. Since it is much more worthwhile to look for weapons with high stat qualities and low passive qualities and reroll the passive, most people tend to reroll these weapons only once to get them to fabled or legendary tier, so the latter would not give much information in these cases. I personally don't see a case for the latter especially since it will only ever be updated to one once someone is satisfied with a rerolled passive, or two if they are feeling daring and get lucky with a good stat roll. The former would be more representative of how many shards went into the weapon which I think is more useful to know.