search

ChristopherChudzicki / math3d

Legacy version: Use math3d-react repo instead
MIT License
12 stars 4 forks source link

Fix navbar to the top #104

Closed stardust66 closed 6 years ago

stardust66 commented 7 years ago

Fixes #103. The added padding-top for the body is to prevent the navbar from covering up part of the page. Is there a better way to do this?

ChristopherChudzicki commented 7 years ago

In #103, you said

Users shouldn't lose access to the title, examples, or the share button when they scroll down.

I completely agree.

But... adding the navbar-fixed-top class to the navbar causes problems for mobile devices. The current navbar is responsive in the sense that it becomes a pull-down menu on small screens:

Current navbar pushes content down: Fixed navbar covers content:
screen shot 2017-06-18 at 7 50 05 pm screen shot 2017-06-18 at 7 50 29 pm

This post on stachexchange might solve the problem. Not sure... it would be great to have a properly fixed navbar.

PS: Regarding mobile user experience, I am under no illusions that it will ever be convenient to edit a graph on a mobile device. However, I do think it is important that the site display existing graphs nicely on a mobile device. (Among other things, it's fun to pull out a phone and show people what we've been working on!)

stardust66 commented 6 years ago

I'm closing this since I don't know how to solve this problem, and it's been a while.