search

ChristopherDavenport / linebacker

Finally Tagless Blocking Implementation
https://christopherdavenport.github.io/linebacker
MIT License
94 stars 7 forks source link

Changes to use the new `ContextShift` from cats-effect #32

Closed tbrown1979 closed 6 years ago

tbrown1979 commented 6 years ago

Gotcha! I'll get that changed 😄

tbrown1979 commented 6 years ago

@ChristopherDavenport Actually, could you elaborate on that a little bit?

If we require the ContextShift for DualContext then that handles the switching back to the "default" pool after evalOn. The construction of a ContextShift[F] that would be used for DualContext would require a default EC. It's not clear to me at the moment why the DualContext would still need to explicitly know about one at that point. Let me know what you think. Thanks 😄

tbrown1979 commented 6 years ago

These changes look great, Chris! Thanks for helping fix it up :)