search

ChristopherHX / github-act-runner

act as self-hosted runner
MIT License
272 stars 14 forks source link

use DOCKER_HOST to set the bind mount #180

Closed ChristopherHX closed 5 months ago

ChristopherHX commented 5 months ago

CC @igagis DOCKER_HOST should no longer use the hardcoded unix socket

it's all about internal settings of nektos/act that were not exposed

igagis commented 5 months ago

So, do we need to always set DOCKER_HOST now, even for docker? This might need a change to script then

igagis commented 5 months ago

Or... I'm confused

ChristopherHX commented 5 months ago

So, do we need to always set DOCKER_HOST now, even for docker? This might need a change to script then

No, default behavior from 2021 has not been touched.

nektos/act set's the config to /var/run/docker.sock if we don't set it externally to an non empty string, it's pretty deep in the code.

igagis commented 5 months ago

Ah, ok, now I got it. Thanks for fast release :)