XBL login broken - Githubissues

guppy42 commented 3 years ago

Issue description

This is not the same issue as #232

When pressing the "sign into xbox" button in game ;

( First launch / after removing data from ~/.local/share/ ): "says signed in / get a r2d2 hat" - but you are not logged in ) ( subsequent launches ) : The sign in page pops up quickly and either closes immediately or does so when you press "sign in" button. The game will then be for ever stuck at "signin into xbox" ( as is the case in #232 ) - but I can't close the game and leave the page open as the page is already closed. Subsequent log in attempt results in "error code: drowned" in game

after repeated attempt the launcher segfaults and causes a hardlockup

Steps to reproduce

download the "new" launcher
download the 1.16.221.01
Play
press the "sign into xbox" button

Things I've tried

removing all launcher and msa folder from ~/.local/share/
using Build 658 sometimes get me far enough to enter my XBL username but the browser closes as soon as I hit enter ( I do get a 2FA request, but as the browser is closes I can't tell what number to pick )
Loggin into the game via the mobile client on the same network works just fine.

System info

Linux version Ubuntu 20.04.2 LTS Kernel version 5.4.0-72-generic #80-Ubuntu SMP Driver and version nouveau: xserver-xorg-video-nouveau/focal,now 1:1.0.16-1 amd64 [installed] Launcher version Appimage Build 661 (x86_64) Game version 1.16.221.01 (x_86_64)

Other notes

I have 2FA enabled on my xbox account

guppy42 commented 3 years ago

Additional note; the flatpak version also has the initial "blip" of pretending to login, but pressing the "sign in" button after this works as expected, if slowly.

ChristopherHX commented 3 years ago

I'm not shure why it's not working for you

I enabled 2fa on my microsoft account using the microsoft authenticator, only to verify your issue
Opened 1.16.221.01 (x86_64)
Pressed sign-in
- Failed the first time with an error, the game wasn't fully loaded. You can press sign in while the game is busy.
- Opened a sign in window
Enter my email
Enter my password
The webview doesn't close, it asked me to check the microsoft authenticator
I agreed on my windows phone
webview closes
webview opens
Allows me to change the account (the previous AppImage issue seems to be resolved server side)
Accept
webview closes
Minecraft mainpage still shows the sign-in button
After a couple of seconds I'm signed in.

I have hard time to reimplement the java sign in flow, so every change to xbox live is time intensive, as result msa is an unused component after 1.16.20.

The webview normally isn't closed before the microsoft page redirects you to the final link, the source of the webview is https://github.com/freundTech/mcpelauncher-webview/tree/cbd635c191184a9cec847dc67b473268a5222f30

I have 2FA enabled on my xbox account

Which 2FA system, if there are multiple? I can sign in with and without 2fa on my machine, I agree it is buggy. Do you have more details? I'm using ubuntu 20.04 focal x86_64 with intel uhd.

You could also use manually sign in if you build with

cmake . -DJNI_USE_JNIVM=ON -DXAL_WEBVIEW_USE_CLI=ON -DXAL_WEBVIEW_USE_QT=OFF -DENABLE_QT_ERROR_UI=OFF -DBUILD_WEBVIEW=OFF
make
sudo make install
mcpelauncher-client -dg ~/.local/share/mcpelauncher/versions/1.16.221.01

https://github.com/minecraft-linux/mcpelauncher-manifest/tree/ng

This will print a url, copy it in a webbrowser. Then paste the result url (ms-xal....) in the console and press enter.

guppy42 commented 3 years ago

Okay more details :D

I don't believe I am ever asked to enter my password, even when it works.
On my other machine I was able to login some time ago ( arround build 648/656 ) Linux Mint 20.01 ( bascially ubuntu 20.04 but with the Cinnamon desktop )
As previously mentioned the flatpak version works

I'll give compiling it a go later but rather than turn webview off is there a way to enable additional debugging for it, my suspicion is that it something in the page segfaults the webview - which would explain why it eventually hardlocks the system.

My system logs for the hard crash looks like this; It means notting to me but it migth mean something to you;

May  4 09:09:31 kernel: nouveau 0000:01:00.0: gr: PGRAPH_VSTATUS2: 00000000 []
May  4 09:09:23 kernel: Code: 8d 67 20 55 53 48 8b 6f 28 48 8b 5d 08 49 39 ec 74 2d 0f 1f 00 48 8b 7d 18 ff 55 10 48 8b 55 00 48 8b 45 08 48 89 ef 48 89 dd <48> 89 42 08 48 89 10 e8 57 f2 72 ff 48 8b 5b 08 4c 39 e5 75 d6 5b
May  4 09:09:23 kernel: mcpelauncher-we[20669]: segfault at 8 ip 00007f4a8b27a9bd sp 00007ffcc34df370 error 6 in nouveau_dri.so[7f4a8a9a5000+e54000]
May  4 09:09:22 kernel: nouveau 0000:01:00.0: Xorg[1296]: validate: -2
May  4 09:09:22 kernel: nouveau 0000:01:00.0: Xorg[1296]: validate: -2
May  4 09:09:22 kernel: nouveau 0000:01:00.0: Xorg[1296]: validate_init
May  4 09:09:22 kernel: nouveau 0000:01:00.0: Xorg[1296]: Unknown handle 0x0000003c
May  4 09:09:22 kernel: ---[ end trace cbcd11a64520b88b ]---
May  4 09:09:22 kernel: R13: 0000000000000014 R14: 0000000000e19768 R15: 0000000001308c70
May  4 09:09:22 kernel: R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000e16760
May  4 09:09:22 kernel: RBP: 0000000040086409 R08: 0000000000000007 R09: 0000000000000000
May  4 09:09:22 kernel: RDX: 00007ffcc34df350 RSI: 0000000040086409 RDI: 0000000000000014
May  4 09:09:22 kernel: RAX: ffffffffffffffda RBX: 00007ffcc34df350 RCX: 00007f4aa469d50b
May  4 09:09:22 kernel: RSP: 002b:00007ffcc34df318 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
May  4 09:09:22 kernel: Code: 0f 1e fa 48 8b 05 85 39 0d 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 0f 1f 44 00 00 f3 0f 1e fa b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 55 39 0d 00 f7 d8 64 89 01 48
May  4 09:09:22 kernel: RIP: 0033:0x7f4aa469d50b
May  4 09:09:22 kernel:  entry_SYSCALL_64_after_hwframe+0x44/0xa9
May  4 09:09:22 kernel: Call Trace:
May  4 09:09:22 kernel: CR2: 00007f4a5c039000 CR3: 00000004030fe004 CR4: 00000000001606e0
May  4 09:09:22 kernel: CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
May  4 09:09:22 kernel: FS:  00007f4a9da5d940(0000) GS:ffff98bb0eb80000(0000) knlGS:0000000000000000
May  4 09:09:22 kernel: R13: ffff98bb0c2d40b0 R14: 0000000000000000 R15: ffff98baf2059438
May  4 09:09:22 kernel: R10: 0000000000000030 R11: ffff98baf2059440 R12: ffffaebd0386bc30
May  4 09:09:22 kernel: RBP: ffffaebd0386bbe8 R08: 0000000000000000 R09: 0000000000000000
May  4 09:09:22 kernel: RDX: 0000000000000010 RSI: ffffaebd0386bb38 RDI: ffffaebd0386bbd8
May  4 09:09:22 kernel: RAX: 00000000fffffffe RBX: ffffaebd0386bbf8 RCX: 0000000000000000
May  4 09:09:22 kernel: RSP: 0018:ffffaebd0386bbc8 EFLAGS: 00010282
May  4 09:09:22 kernel: Code: 00 00 48 8d 55 e0 be 02 00 00 00 48 c7 45 e0 00 00 00 00 48 89 45 e8 e8 71 e5 ff ff 85 c0 75 0a 48 c7 43 08 00 00 00 00 eb b7 <0f> 0b eb f2 e8 fa 08 94 d9 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44
May  4 09:09:22 kernel: RIP: 0010:nvif_vmm_put+0x6d/0x80 [nouveau]
May  4 09:09:22 kernel: Hardware name: LENOVO 10AS002NMX/, BIOS FCKT44AUS 10/24/2013
May  4 09:09:22 kernel: CPU: 3 PID: 20669 Comm: mcpelauncher-we Tainted: G        W  OE     5.4.0-72-generic #80-Ubuntu
May  4 09:09:22 kernel:  sch_fq_codel parport_pc ppdev nfsd auth_rpcgss lp nfs_acl lockd parport grace drm sunrpc ip_tables x_tables autofs4 hid_jabra hid_microsoft ff_memless hid_generic uas usbhid hid usb_storage btrfs zstd_compress raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor raid6_pq libcrc32c raid1 raid0 multipath linear ahci crc32_pclmul libahci lpc_ich i2c_i801 r8169 realtek wmi video
May  4 09:09:22 kernel: Modules linked in: xt_conntrack xt_MASQUERADE nf_conntrack_netlink nfnetlink xfrm_user xfrm_algo xt_addrtype iptable_filter iptable_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 bpfilter br_netfilter bridge stp llc vboxnetadp(OE) vboxnetflt(OE) vboxdrv(OE) aufs overlay binfmt_misc intel_rapl_msr snd_hda_codec_hdmi mei_hdcp intel_rapl_common x86_pkg_temp_thermal intel_powerclamp coretemp snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio snd_usb_audio snd_usbmidi_lib uvcvideo snd_hda_intel snd_intel_dspcfg snd_hda_codec videobuf2_vmalloc videobuf2_memops videobuf2_v4l2 snd_hda_core videobuf2_common snd_hwdep kvm_intel snd_seq_midi snd_seq_midi_event snd_pcm kvm videodev mc crct10dif_pclmul joydev input_leds snd_rawmidi ghash_clmulni_intel aesni_intel nouveau snd_seq crypto_simd cryptd glue_helper rapl snd_seq_device intel_cstate mxm_wmi snd_timer ttm wmi_bmof snd mei_me drm_kms_helper mei i2c_algo_bit fb_sys_fops soundcore syscopyarea sysfillrect sysimgblt mac_hid
May  4 09:09:22 kernel: WARNING: CPU: 3 PID: 20669 at drivers/gpu/drm/nouveau/nvif/vmm.c:68 nvif_vmm_put+0x6d/0x80 [nouveau]
May  4 09:09:22 kernel: ------------[ cut here ]------------
May  4 09:09:14 kernel: Code: 8d 67 20 55 53 48 8b 6f 28 48 8b 5d 08 49 39 ec 74 2d 0f 1f 00 48 8b 7d 18 ff 55 10 48 8b 55 00 48 8b 45 08 48 89 ef 48 89 dd <48> 89 42 08 48 89 10 e8 57 f2 72 ff 48 8b 5b 08 4c 39 e5 75 d6 5b
May  4 09:09:14 kernel: Chrome_InProcGp[20640]: segfault at 8 ip 00007f87ff27a9bd sp 00007f87b1ff9cc0 error 6 in nouveau_dri.so[7f87fe9a5000+e54000]
May  4 09:09:03 systemd: Finished Clean php session files.
May  4 09:09:03 sessionclean: /usr/lib/php/sessionclean: 35: php7.2: not found
May  4 09:09:03 systemd: Starting Clean php session files...
May  4 09:09:01 cron: pam_unix(cron:session): session closed for user root
May  4 09:09:01 sh: (root) CMD (  [ -x /usr/lib/php/sessionclean ] && if [ ! -d /run/systemd/system ]; then /usr/lib/php/sessionclean; fi)
May  4 09:09:01 cron: pam_unix(cron:session): session opened for user root by (uid=0)
May  4 09:08:27 kernel: Code: 84 c0 74 0a 89 ef 31 c0 eb ac 0f 1f 40 00 31 c0 eb d4 66 2e 0f 1f 84 00 00 00 00 00 66 90 41 54 4c 8d 67 20 55 53 48 8b 6f 28 <48> 8b 5d 08 49 39 ec 74 2d 0f 1f 00 48 8b 7d 18 ff 55 10 48 8b 55
May  4 09:08:27 kernel: mcpelauncher-we[20477]: segfault at 100000058 ip 00007f4aeea7999c sp 00007ffc1b54ba50 error 4 in nouveau_dri.so[7f4aee1a4000+e54000]
May  4 09:06:36 systemd: tmp-.mount_MinecrikfORf.mount: Succeeded.
May  4 09:03:58 kernel: Code: 84 c0 74 0a 89 ef 31 c0 eb ac 0f 1f 40 00 31 c0 eb d4 66 2e 0f 1f 84 00 00 00 00 00 66 90 41 54 4c 8d 67 20 55 53 48 8b 6f 28 <48> 8b 5d 08 49 39 ec 74 2d 0f 1f 00 48 8b 7d 18 ff 55 10 48 8b 55
May  4 09:03:58 kernel: mcpelauncher-we[20156]: segfault at 100000187 ip 00007fa17327a99c sp 00007ffc161929f0 error 4 in nouveau_dri.so[7fa1729a5000+e54000]
May  4 09:03:31 kernel: Code: b8 02 00 00 00 89 d1 41 56 41 55 49 89 fd 41 54 49 89 f4 55 89 d5 53 89 d3 48 83 ec 28 83 e5 01 4c 8b 37 4c 8b 7f 48 0f 45 e8 <8b> 7e 08 45 8b 46 18 89 e8 83 c8 04 f6 c2 02 0f 45 e8 c1 e9 09 83
May  4 09:03:31 kernel: Chrome_InProcGp[20034]: segfault at 8 ip 00007fccfc36bc0c sp 00007fcca4ff7f50 error 4 in libdrm_nouveau.so.2.0.0[7fccfc369000+5000]
May  4 09:03:01 kernel: ---[ end trace cbcd11a64520b88a ]---
May  4 09:03:01 kernel: R13: 0000000000000014 R14: 000000000162bb48 R15: 0000000001850560
May  4 09:03:01 kernel: R10: 0000000000000000 R11: 0000000000000246 R12: 0000000001647c80
May  4 09:03:01 kernel: RBP: 0000000040086409 R08: 0000000000000006 R09: 0000000000000000

The log is very short because I had already at that time had one crash from trying to log in.

You can ignore the php bit not sure why it's trying to clean the sessions of an older php version

ChristopherHX commented 3 years ago

The only difference between the flatpak and the appimage is the qt5 version and sandboxing, same source, same webview, different framework bugs.

You are correct after repeating a 2fa login,

the mcpelauncher-webview has the login cached
It only asked me to confirm the login with the microsoft authenticator, but this worked for me.

Maybe delete the files of mcpelauncher-webview in ~/.cache/ and ~/.local/.

I know the game freezes if you try to close it while it do a login, technically there would be a way to force close it. The log is telling me nothing.

ChristopherHX / mcpelauncher-manifest

XBL login broken #251

Issue description

Steps to reproduce

Things I've tried

System info

Other notes