Open markwkjr opened 5 years ago
PR #12 submitted to fix this issue I only fixed this by updating the Tests to include the product_id
Thought it might be good to have discussion around if GdaxClient.GetFills
should be updated though?
Since query must contain either product_id or order_id should an IF statement to check if BOTH of these are null be inserted and throw if that's the case? Why not throw immediately in this library rather than waiting for failure from the API. Thoughts?
Guessing this is perhaps an API change since they've added so many new Products. But need Product now to perform this.
Fixing this with
client.GetFills(productId: "BTC-USD", paging: new PagingOptions<Int32?>
. Working on PR.