Fix using timeout specified in settings

ChristopherRabotin / bungiesearch

UNMAINTAINED CODE -- Elasticsearch-dsl-py django wrapper with mapping generator

BSD 3-Clause "New" or "Revised" License

67 stars 20 forks source link

Fix using timeout specified in settings #137

Closed NullSoldier closed 8 years ago

NullSoldier commented 8 years ago

The TIMEOUT was being ignored because getattr doesn't work on dictionaries for it's keys. It should use the dict.get to get the settings. I also added the first settings test, yay.

diwu1989 commented 8 years ago

this one is very important, would appreciate a new release being made after this is merged

vannitotaro commented 8 years ago

Hi all! :smiley: I agree with @diwu1989 about the need for a new PyPI release, this was a nasty bug... @ChristopherRabotin maybe just after merging my pull request https://github.com/ChristopherRabotin/bungiesearch/pull/147 ? :wink: Thank you for your great job, guys!