signal timer to flush the items buffer

ChristopherRabotin / bungiesearch

UNMAINTAINED CODE -- Elasticsearch-dsl-py django wrapper with mapping generator

BSD 3-Clause "New" or "Revised" License

67 stars 20 forks source link

signal timer to flush the items buffer #144

Closed diwu1989 closed 8 years ago

diwu1989 commented 8 years ago

this is what I meant by using a timer to make sure that the buffer is always flushed every X interval a timer object is created for each sender type that's queuing things

for this PR to be production quality, I need to:

make the flush interval a configurable interval, right now its hard coded as 5s
write unit test for this behavior somehow
double check that there's no race condition

ChristopherRabotin commented 8 years ago

@diwu1989 , the PR itself looks alright, but I prefer not to merge it in until you think it's prod ready.

diwu1989 commented 8 years ago

closing for now until I have time to work on it again.