ChristopherRabotin / bungiesearch

UNMAINTAINED CODE -- Elasticsearch-dsl-py django wrapper with mapping generator
BSD 3-Clause "New" or "Revised" License
67 stars 20 forks source link

Use add_arguments instead of option_list, to support django 1.10. #156

Closed moemen closed 7 years ago

moemen commented 8 years ago

This issue was reported in #152 .

BaseCommand.option_list is dupricated since Django 1.8 and we should use add_arguments instead.

Django 1.7 is no longer supported, so we can drop support for it safely. But if you want to keep supporting it, I can find some way to do it.

Thank you.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 8d371ebb106bd28a25c2bed9c5bff3d4434c26a5 on moemen:master into 2f87ee034f4667304870144bfbaccd8d147c82c6 on ChristopherRabotin:master.

ChristopherRabotin commented 8 years ago

Thanks for the PR. Can you just update the .travis.yml file and remove lines 9 and 10 (cf. https://github.com/ChristopherRabotin/bungiesearch/blob/master/.travis.yml#L9 )? That should completely remove support for Django 1.7 and make the tests pass.

moemen commented 8 years ago

Thank you @ChristopherRabotin .

I'll do this ASAP.

ChristopherRabotin commented 7 years ago

@moemen Any update on this PR? It seems like other users of bungiesearch would like this too. If you don't have the time to finish that up, I can have a look.

moemen commented 7 years ago

Sorry @ChristopherRabotin for being late. I'll finish your comments and push today.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 4c15ed2782eb0646df2d9708c04260f03e8ba825 on moemen:master into 5309a831d4af637fb5aad964dfad8dea20838c67 on ChristopherRabotin:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 3296b9a48985f57c4c8171f1ff230a5d9bde785d on moemen:master into 5309a831d4af637fb5aad964dfad8dea20838c67 on ChristopherRabotin:master.

ChristopherRabotin commented 7 years ago

Looks good. Thanks a lot @moemen !