search

ChristopherRogers1991 / mycroft_routine_skill

Create, run, and schedule routines with Mycroft
GNU General Public License v3.0
30 stars 13 forks source link

Schedule does not like "every day" #18

Open burnsfisher opened 2 years ago

burnsfisher commented 2 years ago

It seems logical that "every day" would be a reasonable response to "what days of the week". And routines does not complain. In fact it actually does add a schedule with nothing where the days should be. However we then get an error from from_crontab called by _schedule_routine which is missing a field.

burnsfisher commented 2 years ago

Having looked at the code a bit (but not having more time), it seems like "every day" would not be hard to add, but one of the biggest problems is that there is no error checking in the "get days" routine. I expect crontab is called with an argument missing for days.