Replace map[std::string->bool] with set. Eliminates strdup memory leaks.

ChristopherWilks / megadepth

BigWig and BAM utilities

Other

91 stars 9 forks source link

Replace map[std::string->bool] with set. Eliminates strdup memory leaks. #1

Closed dnbaker closed 4 years ago

dnbaker commented 4 years ago

Minor change, but I'm looking at more internal details currently.

dnbaker commented 4 years ago

https://github.com/ChristopherWilks/megadepth/compare/master...dnbaker:patch2?expand=1

Next patch: eliminate additional misdirection by maintaining pointers to vectors as keys by replacing them with vectors themselves.

The other change here is that the POSIX getline calls are allocated with malloc rather than free, as malloc machinery isn't guaranteed to work with the free/delete system.