search

Chrisvin / EasyAndroidEmulator

Create Android Emulators using device name/model in a quick & easy manner.
MIT License
11 stars 2 forks source link

Use os.platform instead of command detection #1

Open toddpi314 opened 3 years ago

toddpi314 commented 3 years ago

find on Windows vs nix has different behavior. Blocks like https://github.com/Chrisvin/EasyAndroidEmulator/blob/master/src/index.js#L137-L145 will map to the find tool on nix and fail, since the piped system image data isn't a file system handle.

Consider switching to using os.platform and favoring grep for *nix

Chrisvin commented 3 years ago

Thanks for bringing this to my attention. Will check on this.