Chroma-Case / Chromacase

3 stars 0 forks source link

Front: Make Metronome Loading sound compatible #323

Closed Arthi-chaud closed 11 months ago

Arthi-chaud commented 12 months ago

TODO Before merging

[ ] Try to load the metronome sound as a local asset instead of a remote one
[ ] Wait for @Octopus773 work on the play page
[ ] Rebasing
[x] Lint and run prettier
[x] Make the toggle callback update visual state
[ ] we should prevent the metronome from playing before the song starts
[ ] We should store the metronome sound in the sound store (see pr on native sounds)

To Discuss

[x] Why was a Ref used. (instead of a useState) for the enabled state (hi @zoriya)

zoriya commented 12 months ago

I used a ref to not rerun the useEvent() playing audio when you change the volume or toggle play/pause. This is important to keep the metronome in sync with the score

Arthi-chaud commented 11 months ago

Closing this, everything has moved to #326