search

ChromaticHQ / usher

Custom Robo commands for use on PHP projects.
https://packagist.org/packages/chromatic/usher
11 stars 6 forks source link

Make refresh commands runnable inside container for ddev #205

Open apotek opened 5 months ago

apotek commented 5 months ago

As described in #204, we can't run robo refresh divorced from the host OS when using ddev because unfortunately the ddev-specific implementations are using ddev commands, which cannot be run inside the container.

Removing the reliance on those commands and using native drupal/drush instead, allows us to run the robo refresh sequence entirely within the service container, meaning the developer doesn't have to futz with php versions, composer etc, on the host OS.

Resolves #204

apotek commented 5 months ago

@mmatsoo / @mattdaniel Wondering if either of you have the bandwidth to look at this Usher change, allowing refresh to happen within the container instead of having to run it in the host OS context.

apotek commented 5 months ago

I am going to add this to devops agenda or tech back end meeting of some sort so I can broadcast the implications of this change.

apotek commented 1 month ago

@mattdaniel I'd love your eyeballs on this at some point.

apotek commented 3 weeks ago

Run a comparison on an in-container database load versus using ddev import-db for a site like JFK.

@mattdaniel Makes the point that implementing this does not remove the possibility of using the ddev native database import.

@agarzola It is important to engineer our tooling so that it can be more agnostic, more composable. So the less we build in assumptions about lando or ddev into our tooling and can create implementation-neutral tooling, the better. So our composer commands should prefer to not mention ddev.

apotek commented 2 weeks ago

Going to hold off on merging this until the next devops council so we can broadcast the change and any potential fallout. Also not good to release this during time I am out of office.