ChromaticHQ / usher

Custom Robo commands for use on PHP projects.
https://packagist.org/packages/chromatic/usher
11 stars 6 forks source link

Standardize yaml writing and allow for it to be configurable #215

Closed apotek closed 3 weeks ago

apotek commented 1 month ago

Description

Make yaml writing configurable.

Resolves #214 and also contributes to resolving several issues reported in Benz projects.

Requires https://github.com/ChromaticHQ/usher/pull/211 ✅ to be merged in order to pass tests.

apotek commented 1 month ago

THis is looking good from my side based on just code review - maybe we can check the tests are good once #211 is merged before merging

Thank you. I ended up reviewing and merging Mark's #211 and added some phpcs fixes and now tests are passing. I appreciate the review!