Indenting rules for arrays and case/default statements are incorrect

[tdmalone]

Rule:

Generic.WhiteSpace.ScopeIndent.IncorrectExact

Code:

$var = [
  1, // line 31
  2, // line 32
  3, // line 33
];

Result:

     31 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found
        |       |     2 (Generic.WhiteSpace.ScopeIndent.IncorrectExact)
     31 | ERROR | [x] Array item not aligned correctly; expected 4 spaces but
        |       |     found 2
        |       |     (WordPress.Arrays.ArrayIndentation.ItemNotAligned)
     32 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found
        |       |     2 (Generic.WhiteSpace.ScopeIndent.IncorrectExact)
     32 | ERROR | [x] Array item not aligned correctly; expected 4 spaces but
        |       |     found 2
        |       |     (WordPress.Arrays.ArrayIndentation.ItemNotAligned)
     33 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found
        |       |     2 (Generic.WhiteSpace.ScopeIndent.IncorrectExact)
     33 | ERROR | [x] Array item not aligned correctly; expected 4 spaces but
        |       |     found 2

Desired Result:

Should expect 2 spaces for the array item, and 0 for the line. It seems to be getting confused and thinking there's an extra 2 spaces there?

[tdmalone]

High pri because this is likely to be affecting current work

[tdmalone]

I think this is going to be complicated to look into. I am excluding three troublesome rules for now:

<exclude name="WordPress.Arrays.ArrayIndentation.ItemNotAligned"/>
<exclude name="WordPress.Arrays.ArrayIndentation.MultiLineArrayItemNotAligned"/>
<rule ref="Generic.WhiteSpace.ScopeIndent">
    <properties>
      <property name="exact" value="false"/>
    </properties>
</rule>

[tdmalone]

Two additional rules temporarily excluded due to incorrect indentation problems:

<exclude name="PEAR.Functions.FunctionCallSignature.Indent"/>
<exclude name="PSR2.ControlStructures.SwitchDeclaration.BreakIndent"/>

[tdmalone]

Possible food for thought: https://github.com/squizlabs/PHP_CodeSniffer/issues/761 i.e. we might have conflicting indentation rules - including from upstream.