run Lighthouse CI in actions

ChromeDevTools / debugger-protocol-viewer

DevTools Protocol API docs—its domains, methods, and events

https://chromedevtools.github.io/devtools-protocol/

Other

862 stars 173 forks source link

run Lighthouse CI in actions #138

Closed paulirish closed 4 years ago

paulirish commented 4 years ago

@TimvdLippe since you were using Lighthouse results to evaluate my PR.. i figure we should just automate this. :)

right now it's running with recommended assertions and there's a couple failures. they're fixable.

TimvdLippe commented 4 years ago

Seems like the action is running, but it is catching some failures that I did not observe locally. Are these legitimate issues we should fix or are they unintended?

paulirish commented 4 years ago

*-images failures: legit. we should optimize and rightsize the protocolmonitor image
taptargets: seems probably legit.
uses-http2: eh... seems broken. i dont know why this is failing on localhost.
uses-long-cache-ttl: lol. of course it's google analytics. we can override with a maxlength of 1
dom-size: legit, though we wont be able to fix. might be worth trying tho
render-blocking resources: legit. ideally we inline the css into the html

paulirish commented 4 years ago

im gonna merge and followup with a PR to fix one of these.