ChromeDevTools / debugger-protocol-viewer

DevTools Protocol API docs—its domains, methods, and events
https://chromedevtools.github.io/devtools-protocol/
Other
862 stars 173 forks source link

Update search placeholder to indicate you can start typing immediately #150

Closed TimvdLippe closed 4 years ago

TimvdLippe commented 4 years ago

Not 100% yet, but I think it would be nice to teach users the fact that you can start typing without any interaction with the input box, to immediately start searching. WDYT?

TimvdLippe commented 4 years ago

Ironically I only found out https://vanilla.aslushnikov.com/ does the same, but I wasn't aware of it. Great minds think alike? 😛

googlebot commented 4 years ago

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

paulirish commented 4 years ago

can i sell you on lightening up the placeholder a tad?

image

TimvdLippe commented 4 years ago

Yes looks great thanks!