search

ChromeDevTools / debugger-protocol-viewer

DevTools Protocol API docs—its domains, methods, and events
https://chromedevtools.github.io/devtools-protocol/
Other
862 stars 173 forks source link

chore: update LHCI to use @lhci/cli@next #156

Closed patrickhulce closed 4 years ago

patrickhulce commented 4 years ago

I switched everything that was configured on the action to use CLI flags instead, but could also migrate most of that into the .lighthouserc.js instead if you prefer.

Also added explicit node setup step to make it clear what version is being used.

closes #155

patrickhulce commented 4 years ago

Unfortunately I can't test this because I don't have write access on the repo :/

Perhaps the action could be edited to run on PRs too?

paulirish commented 4 years ago

Perhaps the action could be edited to run on PRs too?

yah. we should probably put in CI docs that you want this on both PR and master push.

patrickhulce commented 4 years ago

we should probably put in CI docs that you want this on both PR and master push.

good call 👍