search

ChromeDevTools / debugger-protocol-viewer

DevTools Protocol API docs—its domains, methods, and events
https://chromedevtools.github.io/devtools-protocol/
Other
860 stars 173 forks source link

Experimental flag #60

Closed paulirish closed 8 years ago

paulirish commented 8 years ago

image

Fixes #30

plz review @dgozman @pavelfeldman

paulirish commented 8 years ago

Previewable at https://paulirish.github.io/debugger-protocol-viewer/

Plz take a look around to confirm things are tagged right.

kdzwinel commented 8 years ago

Thought you were against adding it ;)

  1. Isn't that a little weird that some domains are marked as experimental while only some of their methods/types are marked as experimental? (e.g. CSS.getPlatformFontsForNode ). What's the difference between non-experimental method in experimental domain vs experimental method in experimental domain?
  2. Deprecated domains should link to their successor. As far as I remember, we have that info in protocol.json.
  3. We should probably explain what these badges mean somewhere. EDIT: NVM just saw the title screen shot 2016-08-18 at 23 57 54
  4. If domain is deprecated/experimental we can mark it as such in the menu.
paulirish commented 8 years ago

addressed feedback.

https://paulirish.github.io/debugger-protocol-viewer/ is updated.

paulirish commented 8 years ago

Isn't that a little weird that some domains are marked as experimental while only some of their methods/types are marked as experimental?

yup. i now tag the domain in red and then ignore any subitems that are marked experimental

image

Deprecated domains should link to their successor.

there's only Console right now.. and the description indicates the successor.

kdzwinel commented 8 years ago

LGTM! Love the red outline on the experimental domain box ✨