search

ChromeDevTools / debugger-protocol-viewer

DevTools Protocol API docs—its domains, methods, and events
https://chromedevtools.github.io/devtools-protocol/
Other
860 stars 173 forks source link

Update 1.1 to 1.2 #65

Closed paulirish closed 7 years ago

paulirish commented 7 years ago

Previewable here: https://paulirish.github.io/debugger-protocol-viewer/

To generate the protocol file I..

  1. Took the tot protocol.
  2. Filtered out all experimental domains
  3. within remaining domains, i filtered out experimental types, commands, and events.
  4. removed the Console domain as its deprecated

I left experimental parameters on methods as it seems fairly odd to exclude those. They also appear in the return value (for Page.navigate).

it's viewable here: https://github.com/paulirish/debugger-protocol-viewer/blob/gh-pages/_data/1-2/protocol.json

WDYT?

R=@dgozman, @kdzwinel

fixes #64

dgozman commented 7 years ago

Looks good! Cross-domain links to types do not work though :-)

paulirish commented 7 years ago

good catch. looks like we've had that bug for a while. :) konrad just filed as #66

linclark commented 7 years ago

It looks like Console was removed because it is deprecated, but the Log entry (which replaces some of the functionality) is still experimental, so that's not included either.

kdzwinel commented 7 years ago

Not sure how I feel about 'experimental' flags on something that we call stable, but besides that, LGTM. 👏

The bug that Dmitry mentioned is unrelated. I've created an issue for it #66 .

paulirish commented 7 years ago

@linclark good question. filed as #69 so we can followup there.