search

ChromeDevTools / debugger-protocol-viewer

DevTools Protocol API docs—its domains, methods, and events
https://chromedevtools.github.io/devtools-protocol/
Other
862 stars 173 forks source link

Unable to scroll to the bottom of the list of domains #92

Closed kdzwinel closed 6 years ago

kdzwinel commented 6 years ago

by @gsouf

Hi,

When navigating on the doc hosted on github pages the left menu is not reachable and last items cannot be clicked.

See :

cdp1

Expected result:

cdp2

kdzwinel commented 6 years ago

@TimvdLippe unfortunately, this is still a problem in the new version :( Maybe you'll have an idea what's happening - there are two scroll bars (real one and emulated).

gsouf commented 6 years ago

Not sure it can help, but it appears that the scroll bar scrolls correctly but the element has a css rule specifying position:fixed; bottom: -120px. Replacing with bottom: 0 is what I did to take the second screenshot.

TimvdLippe commented 6 years ago

Hm, it seems that the following selector also works:

#domainContainer {
  height: calc(100vh - 127px);
}

Where 127 is the height of the dropdownmenu + toolbar. I will try to find a maintainable solution for this; can work on it tomorrow.

TimvdLippe commented 6 years ago

Fixed on https://timvdlippe.github.io/devtools-protocol/

Apparently setting the height on a child where the parent has position: fixed; computes the height of the full viewport. Luckily the fix was easy: put it all in a div with height: 100vh; display: flex;.