ChromeDevTools / devtools-protocol

Chrome DevTools Protocol
https://chromedevtools.github.io/devtools-protocol/
BSD 3-Clause "New" or "Revised" License
1.15k stars 226 forks source link

Reference to an experimental type in a non-experimental method #236

Closed zaygraveyard closed 3 years ago

zaygraveyard commented 3 years ago

Target.createTarget() takes an optional browserContextId parameter of type Browser.BrowserContextID But Browser.BrowserContextID is marked as experimental while neither Target, Target.createTarget() or the browserContextId parameter are marked as experimental

So either the parameter should be marked as experimental or the type shouldn't be

https://github.com/ChromeDevTools/devtools-protocol/blob/dee574b5f9d6663dffa0fa6d109c57a0a3010f94/pdl/browser_protocol.pdl#L8154

TimvdLippe commented 3 years ago

This repository is related to Chrome DevTools Protocol, but does not track issues regarding its definition or implementation. If you want to file an issue for the Chrome DevTools Protocol, please open an issue on https://crbug.com under component: Platform>DevTools>Platform. Thanks in advance!

zaygraveyard commented 3 years ago

For reference, here it is: https://bugs.chromium.org/p/chromium/issues/detail?id=1254337