ChromeDevTools / devtools-protocol

Chrome DevTools Protocol
https://chromedevtools.github.io/devtools-protocol/
BSD 3-Clause "New" or "Revised" License
1.15k stars 226 forks source link

Remove DevTools "prompt" permission override option #285

Closed kzar closed 2 years ago

kzar commented 2 years ago

The DevTools protocol[1] allows permissions for websites to be overriden. As well as "granted"/"denied" the override could also be for "prompt"[2], which should have forced the permission re-requested every time. In practice however, the "prompt" override wasn't working correctly. The changes required to fix that proved to be too invasive[3], so we decided[4] to remove the option instead.

1 - https://chromedevtools.github.io/devtools-protocol/tot/Browser/#method-setPermission 2 - https://chromedevtools.github.io/devtools-protocol/tot/Browser/#type-PermissionSetting 3 - https://chromium-review.googlesource.com/c/chromium/src/+/3683443 4 - https://crbug.com/1319943#c13

kzar commented 2 years ago

So far the "prompt" permission override option doesn't work correctly, I attempted to fix that but in the end I think folks agree that it would be better to instead remove the option. We discussed in https://crbug.com/1319943 and https://chromium-review.googlesource.com/c/chromium/src/+/3683443.

I'm not sure if these changes are sufficient, or if we'll need to remove the option elsewhere as well. This is all new to me. Please shout if I need to do anything else, or if this change is somehow wrongheaded!

kzar commented 2 years ago

_(Closing this, since these files are generated from browser_protocol.pdl in the Chromium repository.)_

paulirish commented 9 months ago

Situation got summarized here: https://issues.chromium.org/issues/40836451#comment24