Closed diego-fernandez-santos closed 4 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
I signed it!
El vie., 28 sept. 2018 19:59, googlebot notifications@github.com escribió:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version https://opensource.google.com/docs/cla/#troubleshoot).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
- The email used to register you as an authorized contributor must also be attached to your GitHub account https://github.com/settings/emails.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChromeDevTools/timeline-viewer/pull/61#issuecomment-425517743, or mute the thread https://github.com/notifications/unsubscribe-auth/AJrFvOYwScgRLT9CdccBCfLb6EWP7dFrks5ufmNrgaJpZM4W_Kdj .
--
"Este mensaje está dirigido de manera exclusiva a su destinatario y puede contener información privada y confidencial. No lo reenvíe, copie o distribuya a terceros que no deban conocer su contenido. En caso de haberlo recibido por error, rogamos lo notifique al remitente y proceda a su borrado, así como al de cualquier documento que pudiera adjuntarse.
Por favor tenga en cuenta que los correos enviados vía Internet no permiten garantizar la confidencialidad de los mensajes ni su transmisión de forma íntegra.
Las opiniones expresadas en el presente correo pertenecen únicamente al remitente y no representan necesariamente la opinión del Grupo BBVA."
"This message is intended exclusively for the adressee and may contain privileged and confidential information. Please, do not disseminate, copy or distribute it to third parties who should not receive it. In case you have received it by mistake, please inform the sender and delete the message and attachments from your system.
Please keep in mind that e-mails sent by Internet do not allow to guarantee neither the confidentiality or the integrity of the messages sent."
CLAs look good, thanks!
@paulirish @denar90 May you please provide some feedback on this PR? Is this repository opened to external contributions? We are actively using this on premise but we have had to make our own fork due to this "issue".
Great piece of software anyway!
Thanks!
@diego-fernandez-santos thanks for PR. LGTM. @alfonso-presa it's PR welcome repo, but neither I or other none Googlers can't collaborate, I suppose due to some policy. Unfortunately, they're not so many resources to manage this repo. So we should kindly ask @paulirish to look at it and merge.
@denar90 Thank you for the quick response and the feedback. We are not in a hurry ourselves (we are a little bit uncomfortable maybe ;-) ). I just wanted to check if we could expect this to arrive to trunk at some point or we should have to live detached for ever. Knowing that getting this merged is a possibility is enough for us. Let's give Paul (not even going to mention him to avoid spamming) as much time as he needs to review.
Thanks!
Hello,
I would like to use you app to visualize private timelines reports.
The timeline-viewer and the timelines reports are in the same domain but now it doesn't work fine because the app thinks that is a local resouce and forward the request to the original one.