search

ChromeGaming / Dot-Box

Dot-Box is a game where players take turns drawing lines between dots to create boxes. The player who completes the most boxes wins. It's a simple yet strategic game enjoyed by people of all ages.
https://chromegaming.github.io/Dot-Box/
MIT License
104 stars 190 forks source link

[Bug]: Dot-Box game is not at all responsive for mobile devices #237

Closed mondalsurojit closed 2 months ago

mondalsurojit commented 3 months ago

Give a brief about the bug ✍️

Description The Dot-Box game is not at all responsive for mobile devices.

Screenshot (296)

What is the expected behavior? 🤔

Description The Dot-Box game must have been responsive, and adaptive to all type of mobile screen sizes

Provide step by step information reproduce the bug 📄

Description

Open the site: https://gamesphere-multiplayer.github.io/Dot-Box/ in a mobile device

Select program in which you are contributing

GSSoC24

Code of Conduct

Urgency (Optional)

High priority

github-actions[bot] commented 3 months ago

Hey @mondalsurojit! 👋

👉 Thanks for opening this issue. We appreciate your contribution and will look into it as soon as possible. 👉 Don’t forget to star our Dot-Box and Follow Us on GitHub 👉 Make sure you join our Discord, we have created separate channels for all projects

akarshi19 commented 3 months ago

Please assign this issue to me under GSSoC'24

mondalsurojit commented 3 months ago

@Durgesh4993 Hello sir, I went through the code, and found that the code currently is highly interlinked. When I try to fix something, its directly or indirectly affecting the other part of the code. To fix this, I have to refactor several things, like I have to seperate the settings page from the game page (I will use local storage to store the settings values and once the player click 'Start', it will take the user to the game page and in the game page the settings values will be retrieved from the local storage). Seperation of logic is very important as more contributions will make this very complex overtime. If I have your permission, I will work on to fix the whole setup, as fixing just a part using hacks, will cause problem now or later.

Durgesh4993 commented 3 months ago

@mondalsurojit delete your old code and reclone repo again

mondalsurojit commented 3 months ago

@Durgesh4993 I did it. But nothing is different...

So should I go ahead with my above proposition...? If I get your permission, I would also request you to mark it as a level 3 issue, as refactoring the whole code, needs a lot of effort...but., I am kind of interested in this project, so I don't mind giving my best...

github-actions[bot] commented 2 months ago

Thank you for your contribution! If you have any questions or need further assistance, feel free to reach out to us on our Discord server: Discord. We have separate channels for all projects. Happy coding! 🚀

Connect with us on social media:

ayush-t02 commented 2 months ago

@mondalsurojit as for the refactoring issue, just make it a rule to "pull before push". Always work on the most updated code.

mondalsurojit commented 2 months ago

@ayush-t02 Ok sir...

mondalsurojit commented 2 months ago

@ayush-t02 Sir, can you please also update the level tag here (PR)...