search

ChromeGaming / Dot-Box

Dot-Box is a game where players take turns drawing lines between dots to create boxes. The player who completes the most boxes wins. It's a simple yet strategic game enjoyed by people of all ages.
https://chromegaming.github.io/Dot-Box/
MIT License
95 stars 181 forks source link

fixed reset button issue no. #391 #416

Closed Aradhyajha closed 1 week ago

Aradhyajha commented 1 week ago

PR Description 📜

Fixes # 391

"fixed reset button by changing some code in index.js"

ayush-t02 commented 1 week ago

resolve conflicts and add a demo video

Aradhyajha commented 1 week ago

https://github.com/ChromeGaming/Dot-Box/assets/130289875/b991819f-5824-4fab-9cf9-0ca8f86529fc

@ayush-t02 .. sir before i made the changes while clicking on the reset button it automatically set to empty one but after i made the changes the no. of rows and columns equal to 6 as set to the default one... please u check the video once..

ayush-t02 commented 1 week ago

why have you closed the PR?

Aradhyajha commented 1 week ago

Sir may I raise the pr again

On Fri, Jun 28, 2024, 9:27 AM Ayush Tripathi @.***> wrote:

why have you closed the PR?

— Reply to this email directly, view it on GitHub https://github.com/ChromeGaming/Dot-Box/pull/416#issuecomment-2196088844, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7CBBU7LTPCRAXTA5UPPRFTZJTNMBAVCNFSM6AAAAABJ7DZ77OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJWGA4DQOBUGQ . You are receiving this because you modified the open/close state.Message ID: @.***>

Aradhyajha commented 6 days ago

Sir can you please give some suggestions regarding this

On Fri, Jun 28, 2024, 9:34 AM Aradhya Jha @.***> wrote:

Sir may I raise the pr again

On Fri, Jun 28, 2024, 9:27 AM Ayush Tripathi @.***> wrote:

why have you closed the PR?

— Reply to this email directly, view it on GitHub https://github.com/ChromeGaming/Dot-Box/pull/416#issuecomment-2196088844, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7CBBU7LTPCRAXTA5UPPRFTZJTNMBAVCNFSM6AAAAABJ7DZ77OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJWGA4DQOBUGQ . You are receiving this because you modified the open/close state.Message ID: @.***>

ayush-t02 commented 6 days ago

create a new issue -> create a new PR for new issue

Aradhyajha commented 6 days ago

Sir for solving the reset button may I need to create new issue

On Sat, Jun 29, 2024, 11:14 AM Ayush Tripathi @.***> wrote:

create a new issue -> create a new PR for new issue

— Reply to this email directly, view it on GitHub https://github.com/ChromeGaming/Dot-Box/pull/416#issuecomment-2197993707, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7CBBU26IOYGENALW2JFIOTZJZCTJAVCNFSM6AAAAABJ7DZ77OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJXHE4TGNZQG4 . You are receiving this because you modified the open/close state.Message ID: @.***>